The concentration, distribution and modes of occurrence of trace elements in thirty coals, four floors and two roofs from Northern China were studied. The samples were collected from the major coalfields of Shanxi Province, Shaanxi Province, Inner Mongolian Autonomous Region, and Ningxia Hui Autonomous Region. The concentrations of seventeen potential hazardous trace elements, including Hg, As, Se, Ph, Cd, Br, Ni, Cr, Co, Mo, Mn, Be, Sb, Th, V, U, Zn, and five major elements P, Na, Fe, Al, and Ca in coals were determined. Compared with average concentration of trace elements in Chinese coal, the coals from Northern China contain a higher concentration of Hg, Se, Cd, Mn, and Zn. They may be harmful to the environment in the process of combustion and utilization. Vertical variations of trace elements in three coal seams indicated the distributions of most elements in coal seam are heterogeneous. Based on statistical analyses, trace elements including Mo, Cr, Se, Th, Ph, Sb, V, Be and major elements including Al, P shows an affinity to ash content. In contrast, Br is generally associated with organic matter. Elements As, Ni, Be, Mo, and Fe appear to be associated with pyrite. The concentrations of trace elements weakly correlate either to coal rank or to maceral compositions. (c) 2006 Elsevier B.V. All rights reserved.