A ZnO/CdS core-shell nanorod structure is studied for use as photoanode in photoelectrochemical cell for water splitting. The focus is to examine the effect of hydrogen and/or nitrogen doping of ZnO nanorods on its performance as photoanode. ZnO nanorods hydrothermally synthesized on ITO glass substrate are heat-treated in pure hydrogen ambient and then in atmospheric pressure of ammonia for H- and N-doping of ZnO. The H- and/or N-doped ZnO nanorod structure (N/H:ZnO) reveal an enhanced photo current and photo-to-current conversion efficiency in comparison to untreated ZnO nanorods by shifting the absorption edge towards visible region and increasing absorption of infrared region wavelengths. CdS sensitization of the nanorods is also studied. The morphology and properties of the samples are examined by SEM, XRD, UV-vis absorption and photoluminescence. Optimization of the ZnO nanorod growth and CdS coating processes are also undertaken. An optimized N/H:ZnO nanorods sensitized by CdS layer yields a photocurrent density of similar to 12.61 mA cm(-2) at 0 V (vs. SCE) and photon-to-current conversion efficiency of similar to 4.5% (at -0.73 V vs. SCE) in 0.5 M Na2S solution under a simulated solar light. The H-2 gas generation with the optimal structure is about 6 mL h(-1) cm(-2). (C) 2016 Elsevier B.V. All rights reserved.