Development of hierarchical core-shell semiconductor heterostructures ensue significant advancement in catalytic functional structures with improvised optical functionalities. Shell wall controlled vertically aligned ZnO-ZnS core-shell nanorod (NR) heterostructures were grown on transparent conductive substrates along the c-axis by sulfidation of aligned ZnO nanorod arrays for visible photocatalytic properties. The effects of the sulfidation time on the morphology, crystalline properties, optical property, photocurrent response, and photocatalytic activity of the catalyst arrays were studied under UV and visible light irradiation. The shell wall thickness of these heterostructures influenced in great extent the effective photo responsive charge separation and improved carrier mobility. ZnO-ZnS core-shell heterostructure having the shell wall thickness of 20 nm has exhibited more efficient visible photocatalytic behavior due to effective separation of carriers and improved visible absorption. On further increasing the wall thickness the catalytic efficiency was reduced due to the poor carrier (hole) mobility in the polycrystalline shell grains which induced the higher recombination rate. Stability and reusability of ZnO-ZnS core-shell nanostructures reveals that the ZnS acted as a protective layer over the ZnO NR arrays. In appraisal with ZnO NR arrays, the control over the shell wall thickness of ZnO-ZnS core-shell NR array attributed to the excellent visible photocatalytic activity and improvised absorption of light in visible region at ZnO-ZnS interface and effective separation of photogenerated electron-hole pairs at ZnO-ZnS heterojunctions.