The CoNi2S4/CdWO4-3 (CNS/CW-3) was an excellent photocatalyst for hydrogen evolution. The controlled morphology of CNS/CW-3 was successfully by adding thiourea as sulfur source and TBA to control the CoNi2S4 nanoparticles. The photocatalytic hydrogen evolution activity of CoNi2S4 and CdWO4 under visible light irradiation was studied with different CoNi2S4 incorporation ratios. UV-vis absorption spectra showed that the absorbance of CNS/CW-3 composite catalyst increased significantly after doping CoNi2S4. The electrochemical and photoelectrochemical experiments also showed that the charge separation and electron transfer efficiency were higher when CoNi2S4 was attached to CdWO4. CNS/CW-3 exhibited excellent photocatalytic activity for hydrogen evolution under visible light irradiation. Its hydrogen evolution activity reached 269.08 mu mol in 5 h, and had good light stability. It was a potential strategy to design photocatalyst with controllable morphology.