Electrochemical water-splitting is widely regarded as one of the essential strategies to produce hydrogen energy, while Metal-organic frameworks (MOFs) materials are used to prepare electrochemical catalysts because of its controllable morphology and low cost. Herein, a series of trimetallic porous Pt-inlaid Ni-Fe nanocubes (NCs) are developed with bifunctions of hydrogen evolution reaction (HER) and oxygen evolution reaction (OER). In the process of prepare the electrochemical catalysts, Pt nanoparticles are uniformly embedded in the Fe-Ni PBA cube structure, and ascorbic acid is employed as a reducing agent to reduce Pt2+ to Pt nanoparticles. In this work, the cubic structure of Fe-Ni PBA is maintained and the noble metal Pt nanoparticles are embedded. Remarkably, the formation of PBA cubes, Pt inlay and reduction are completed in one step, and Pt nanoparticles are embedded by a simple method for the first time. By employing acid etching method, a porous structure is formed on the PBA cube, which increases the exposed area of the catalyst and provides more active sites for HER and OER. Due to the porous structure, highly electrochemical active surface area and the embedded of highly dispersed Pt nanoparticles, the porous 0.6 Ni-Fe-Pt nanocubes (NCs) exhibits excellently electrocatalytic performance and durable stability to HER and OER. In this work, for HER and OER, And Tafel slopes are 81 and 65 mV dec(-1), the overpotential n at the current density of 10 mA cm(-2) are 463 and 333 mV, and the onset potential are 0.444 and 1.548 V, respectively. And after a 12-h i-t test and 1000 cycles of cyclic voltammetry (CV), it maintained high stability and durability. This work opens up a new preparation method for noble metal embedded MOF materials and provided a new idea for the preparation of carbon nanocomposites based on MOF. (C) 2020 Hydrogen Energy Publications LLC. Published by Elsevier Ltd. All rights reserved.