The concentrations of forty-five elements in 137 Chinese coals collected from the main coal fields and representing the main coal-forming periods were determined using instrumental neutron activation analysis (INAA), atomic absorption spectrometry (AAS), inductively coupled plasma atomic emission spectrometry (ICP-AES), and atomic fluorescence spectrometry (AFS). Among the elements determined are the following minor and trace elements which are important to environmental protection and human health: As, Cd, Ph, Hg, Se, Mn, Ni, Cu, Zn, Sb, Co, Mo, F, Cl, V, Ba, U and Th. The ranges and means of concentrations of these elements are given. Comparison with world averages and geometric means of concentrations in American coals shows that the concentrations of most elements are higher in Chinese coals. However, it is necessary to point out that although the samples are representative, the number of samples is small. Hence, these are only preliminary results. Finally, five major genetic types of enrichments of minor and trace elements in Chinese coals are proposed on the basis of Chinese coal geology, namely, source-rock-controlled type; sedimentation-controlled type; magmatic/hydrothermal-controlled type; fault-controlled type; and groundwater-controlled type.